Remove -fdebug-prefix-map for toolchain #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Jan 14, 2025
The relative paths to toolchain components in binaries does not affect hermeticity. It's possible these affect debugging instead, in which case remapping them requires users to add reverse maps in their debugger config. Instead leaving the paths as is makes these "just work" if users have an external/ symlink in the root of their repo (which is common for compile_commands.json as well).
fmeum
force-pushed
the
ks/remove-fdebug-prefix-map-for-toolchain
branch
from
73a19f5 to
33729a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative paths to toolchain components in binaries does not affect
hermeticity. It's possible these affect debugging instead, in which case
remapping them requires users to add reverse maps in their debugger
config. Instead leaving the paths as is makes these "just work" if users
have an external/ symlink in the root of their repo (which is common for
compile_commands.json as well).