Implement latest requirements #472
Open
+531
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2025
helly25
force-pushed
the
feat/latest_requirements
branch
from
0c7f806 to
e95fc76
Compare
helly25
force-pushed
the
feat/latest_requirements
branch
from
e37d81d to
584e56c
Compare
helly25
force-pushed
the
feat/latest_requirements
branch
from
584e56c to
ce67f1f
Compare
|
@fmeum this is ready from my end now, I'd appreciate any feedback. I added a concrete practical goal to the PR description. |
Add a test for the distribution finder. The test computes what would be found given all versions a nd a combination of arch and os. Then the test compares the result to what is configured and shows the difference. If the difference is empty then the finder is correct. There are currently only deleted entries with the last deleted enty in version 18.1.0. In other words starting with llvm version 18.1.1 the finder is correct. That also means as long as this is true, when someone adds information for a new version then the test does not need to be updated.
This allows to specifically require ranges, including minimum and maximum versions as well as version exclusions. That can be easier than figuring out which versions are available for which platform. Further this allows to automatically pick up relevant versions automatically as they become available later.
…at is not setup correctly. Since it s going away there is also no point in adding and fixing it now.
Need to upgrade external helly25_bzl to 0.1.2 to fix its workspace file. Also important: Add the strip_prefix. Otherwise the workspaces dump the repo including the root directory. As a result the files cannot be found and BAzel only states there is no BUILD file. It should possibly suggest there is no such directory and no such bzl file in the first place.
…rrect version order.
helly25
force-pushed
the
feat/latest_requirements
branch
from
f983ee3 to
5467126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #473
This builds on PR #471
This PR allows requirements support for the LLVM versions like
llvm_version = "first"andllvm_version = "latest"which will effectively find the first and latest LLVM version respectively. For many people this will be the easiest way to get started and solves the issue that not always all arch/os versions have been prepared for all LLVM versions. It also means you do not have to know whether the basename starts with "LLVM" or "clang_llvm", in which order arch and os have to be provided and how the os is exactly specified.We further add the ability to specify requirements, including minimum and maximum versions as well as version exclusions. That can be easier than figuring out which versions are available for which platform. Further this allows to automatically pick up relevant versions automatically as they become available later. Example:
The requirements strings mostly follow semver specs and support
<,<=,>,>=,==and!=. They only currently work for version componentsmajor,minorandpatch. Since we do not list other versions in our config that is fine for now.One practical goal for this PR is to be able to run automatic tests with updated LLVM versions in the easiest possible way. Using the new extra_llvm_versions we can now easily run automated CI/CD tests against different LLVM branches. Say:
llvm_version = 'latest:>=15,<16'llvm_version = 'latest:>=19,<20'llvm_version = 'latest:>=20,<21'That above list would be used in three separate CI/CD runs that would then test the 15, 19 and 20 branches respectively. When new distributions get added upstream or locally, they can easily be added via the new
extra_llvm_distributionsand will be picked up by the setup without any further change.