Skip to content

Windows exe #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

helly25
Copy link
Contributor

@helly25 helly25 commented Apr 26, 2025

For V19+:

  • add win32.exe, win64.exe and woa.exe distributions.
  • find win32.exe and woa64.exe distributions automatically.

The exe files are self extracting installers, not msiexe. However, we can extract them with a separate tool, say 7z.

@fmeum
Copy link
Member

fmeum commented Apr 26, 2025

The change looks good, but is toolchains_llvm set up to do anything with an .exe? I've never used LLVM on Windows, but isn't that an installer?

@helly25
Copy link
Contributor Author

helly25 commented Apr 26, 2025

The change looks good, but is toolchains_llvm set up to do anything with an .exe? I've never used LLVM on Windows, but isn't that an installer?

I'm still at my mac/linux machines and will have to figure out how I can actually teach the toolchain to work with them. Unfortunately Bazel does not use a tool for such SFX files and the toolchains will need to add support in the download implementation.

At the moment our _windows functions will return either LLVM-{llvm_version}-win32.exe or LLVM-{llvm_version}-win64.exe which is incorrect and wrong in several ways. The PR in its current form at least is a step forward.

But I'll need to work upstairs later with a windows machine to see how I can get it actually working.

helly25 added 3 commits April 27, 2025 09:07
* add win32.exe, win64.exe and woa.exe distributions.
* find win32.exe and woad64.exe distributions automatically.
@helly25 helly25 force-pushed the feat/windows.exe_20250426 branch from 6eb71f2 to f8ebf12 Compare April 27, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants