Verify the current resolution #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helly25
added a commit
to helly25/bazel-toolchain
that referenced
this pull request
Apr 28, 2025
* Split `llvm_release_name` into two: * `llvm_release_name_host_info`: Used to verify the resolution. It does not take a rctx. * `llvm_release_name_context`: Will fail if resolution from rctx fails. * Change `dist_version_arch` to `host_info` which returns a struct, so the result can easily be extended and only one call is needed.
Show a selection as ERROR if the selected arch differs from the specified arch.
…fail that explains what to do.
helly25
force-pushed
the
feat/verify_resolution_20250427
branch
from
06987ab to
5830340
Compare
|
@fmeum Any chance you can review and we can progress on this? I want to use this as a basis and verification of improvements to finding targets automatically. |
fmeum
reviewed
May 3, 2025
|
@fmeum any other comments/questions/concerns? |
fmeum
approved these changes
May 10, 2025
helly25
added a commit
to helly25/bazel-toolchain
that referenced
this pull request
May 10, 2025
helly25
added a commit
to helly25/bazel-toolchain
that referenced
this pull request
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm_release_nameinto two:llvm_release_name_host_info: Used to verify the resolution. It does not take a rctx.llvm_release_name_context: Will fail if resolution from rctx fails.dist_version_archtohost_infowhich returns a struct, so the result can easily be extended and only one call is needed.As can be seen in
toolchain/internal/llvm_distributions.golden.sel.txtthere are a number of decisions taken in modeautothat lead to failures in predicting a correct LLVM distribution. Those we should fix.