Skip to content

Run the bootclasspath through ijar #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Run the bootclasspath through ijar #324

wants to merge 3 commits into from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Sep 25, 2025 •
edited
Loading

This reduces disk space and cache usage and should speed up Turbine actions.

ls -lah bazel-out/darwin_arm64-fastbuild/bin/external/rules_java+/toolchains/platformclasspath*.jar 
-r-xr-xr-x@ 1 fmeum    24M Sep 25 11:36 bazel-out/darwin_arm64-fastbuild/bin/external/rules_java+/toolchains/platformclasspath.jar
-r-xr-xr-x@ 1 fmeum   133M Sep 25 11:36 bazel-out/darwin_arm64-fastbuild/bin/external/rules_java+/toolchains/platformclasspath_unstripped.jar

@fmeum fmeum requested review from comius and a team as code owners September 25, 2025 09:39
@fmeum
Copy link
Contributor Author

fmeum commented Sep 25, 2025

@hvadehra @cushon I'll work on ijar-ing system as a follow-up.

@fmeum
Run the bootclasspath through ijar
e94f1ff 
This reduces disk space usage and should speed up Turbine actions.
@fmeum fmeum force-pushed the ijar-bootclasspath branch from c138c4a to e94f1ff Compare September 25, 2025 09:43
cushon
cushon previously approved these changes Sep 25, 2025
View reviewed changes
@fmeum fmeum requested a review from cushon September 25, 2025 15:13
@copybara-service copybara-service bot closed this in 6a30ab8 Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius Awaiting requested review from comius comius is a code owner

@cushon cushon Awaiting requested review from cushon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @cushon