Add support for `--compile_one_dependency` #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

illicitonion merged 3 commits into bazelbuild:main from william-smith-skydio:compile_one_dependency

Apr 3, 2024

Contributor

william-smith-skydio commented Apr 1, 2024

The --compile_one_dependency flag (docs) changes bazel build etc. to accept a file path and build the target corresponding to that file. This is useful for check-on-save with rust-analyzer in combination with the newly-added $saved_file command substitution (rust-lang/rust-analyzer#15476).

Officially --compile_one_dependency only supports the builtin C++ and Java rules, but an undocumented flag can be added to attributes to turn them into sources supporting --compile_one_dependency. I'm not sure what the status of this support is, but it appears to work for all bazel versions up to at least 7.1.1, and if support is removed the flag is pretty harmless.

Before this change:

> bazel build --compile_one_dependency tools/rust_analyzer/main.rs
WARNING: Target pattern parsing failed.
ERROR: Couldn't find dependency on target '//tools/rust_analyzer:main.rs'
ERROR: Couldn't find dependency on target '//tools/rust_analyzer:main.rs'
INFO: Elapsed time: 0.956s
INFO: 0 processes.
ERROR: Build did NOT complete successfully

After:

> bazel build --compile_one_dependency tools/rust_analyzer/main.rs
INFO: Analyzed target //tools/rust_analyzer:gen_rust_project (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //tools/rust_analyzer:gen_rust_project up-to-date:
  bazel-bin/tools/rust_analyzer/gen_rust_project
INFO: Elapsed time: 0.341s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

william-smith-skydio and others added 2 commits

April 1, 2024 09:46


          Add support for --compile_one_dependency.

097e7da


          Merge branch 'main' into compile_one_dependency

40cba69

Collaborator

illicitonion commented Apr 2, 2024

This looks reasonable - do you think there's a reasonable way to add a test for this behaviour?


          Add test for --compile_one_dependency

1887eea

Contributor Author

william-smith-skydio commented Apr 2, 2024

I added a test, which I think should work. I'm not 100% sure since I haven't worked with the bazel CI system before.

illicitonion approved these changes

View reviewed changes

Collaborator

illicitonion left a comment

Thanks!

illicitonion added this pull request to the merge queue

Merged via the queue into bazelbuild:main with commit 2e460de

3 checks passed

rrbutani referenced this pull request in bazel-contrib/toolchains_llvm


          Update dependency rules_rust to v0.42.0 (#313)

3d9f02b

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rules_rust](https://togithub.com/bazelbuild/rules_rust) |
http_archive | minor | `0.41.1` -> `0.42.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_rust (rules_rust)</summary>

###
[`v0.42.0`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.42.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_rust/compare/0.41.1...0.42.0)

### 0.42.0

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-XT1YVJ6FHJTXBr1v3px2fV37/OCS3dQk3ul+XvfIIf8=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.42.0/rules_rust-v0.42.0.tar.gz"],
)
```

Additional documentation can be found at:
https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

- Fix crates.io URL by
[@&#8203;ericmcbride](https://togithub.com/ericmcbride) in
[https://github.com/bazelbuild/rules_rust/pull/2597](https://togithub.com/bazelbuild/rules_rust/pull/2597)
- Add support for `--compile_one_dependency` by
[@&#8203;william-smith-skydio](https://togithub.com/william-smith-skydio)
in
[https://github.com/bazelbuild/rules_rust/pull/2598](https://togithub.com/bazelbuild/rules_rust/pull/2598)
- Update rules_apple by
[@&#8203;sgowroji](https://togithub.com/sgowroji) in
[https://github.com/bazelbuild/rules_rust/pull/2602](https://togithub.com/bazelbuild/rules_rust/pull/2602)
- Support building more things with bzlmod by
[@&#8203;matts1](https://togithub.com/matts1) in
[https://github.com/bazelbuild/rules_rust/pull/2601](https://togithub.com/bazelbuild/rules_rust/pull/2601)
- Make bazel lock file cross-platform by
[@&#8203;cameron-martin](https://togithub.com/cameron-martin) in
[https://github.com/bazelbuild/rules_rust/pull/2453](https://togithub.com/bazelbuild/rules_rust/pull/2453)
- Added Rust 1.77.1 by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2591](https://togithub.com/bazelbuild/rules_rust/pull/2591)
- Fix (+) In vendored crates semver metadata by
[@&#8203;ericmcbride](https://togithub.com/ericmcbride) in
[https://github.com/bazelbuild/rules_rust/pull/2579](https://togithub.com/bazelbuild/rules_rust/pull/2579)
- Keep default_features parity from bzlmod to workspace by
[@&#8203;Lev1ty](https://togithub.com/Lev1ty) in
[https://github.com/bazelbuild/rules_rust/pull/2606](https://togithub.com/bazelbuild/rules_rust/pull/2606)
- clippy: use --cap-lints=warn; apply clippy_flags when
capture_output=True by [@&#8203;goffrie](https://togithub.com/goffrie)
in
[https://github.com/bazelbuild/rules_rust/pull/2451](https://togithub.com/bazelbuild/rules_rust/pull/2451)
- Added Rust 1.77.2 by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2608](https://togithub.com/bazelbuild/rules_rust/pull/2608)
- Re-vendor crate_universe outputs by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2609](https://togithub.com/bazelbuild/rules_rust/pull/2609)
- Release 0.42.0 by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2610](https://togithub.com/bazelbuild/rules_rust/pull/2610)

#### New Contributors

- [@&#8203;Lev1ty](https://togithub.com/Lev1ty) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2606](https://togithub.com/bazelbuild/rules_rust/pull/2606)

**Full Changelog**:
bazelbuild/rules_rust@0.41.1...0.42.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet