build: workaround LLVM bug on Windows #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outliner does not correctly handle landingpads and will attempt to outline the EH funclet which generates incorrect IR (and is also pointless). Workaround this for the time being.
compnerd
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins and
thii
as code owners
|
Is there any issue link or test we can add so we know when it's fixed? |
|
I think that I had opened an issue for this? Let me check. |
keith
approved these changes
May 24, 2022
|
The repro in llvm/llvm-project#40056 works fine now. Do we have another testcase to work with? |
|
I don't have a simple reproducer, but building apple/SourceKit-LSP in release mode should trigger it (I think it might even show up in just apple/indexstore-db in release mode). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outliner does not correctly handle landingpads and will attempt to
outline the EH funclet which generates incorrect IR (and is also
pointless). Workaround this for the time being.