This repository was archived by the owner on Mar 19, 2025. It is now read-only.
Cleanup our Docker dev env. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the services onto a common network shared by all other apps. Don't remove volumes on restart and rebuild. The dev can do that if they need to b/c they want to nuke everything. We should rely on a generally working env and not require nuking the volumes in the normal dev flow. Use COPY instead of ADD b/c ADD wasn't doing what I thought it was. COPY is recommended and volumes are mounted through the docker-compose.yml file so that changes to files inside and outside the container are reflected in both places.
StetsenTech
approved these changes
Sep 12, 2019
| @@ -8,7 +8,7 @@ RUN echo "deb [check-valid-until=no] http://archive.debian.org/debian jessie-bac | |||
| RUN sed -i '/deb http:\/\/deb.debian.org\/debian jessie-updates main/d' /etc/apt/sources.list | |||
|
|
|||
| # Note: gettext is installed to be able to use envsubst to inject config values | |||
| RUN apt-get -o Acquire::Check-Valid-Until=false update -qq && apt-get install -y build-essential libpq-dev gettext | |||
| RUN apt-get -o Acquire::Check-Valid-Until=false update -qq && apt-get install -y build-essential libpq-dev gettext vim | |||
|
Unrelated to this change, i tried to rebuild this container to get teh volume mounted and there are now |
…reflected inside.
This is done by mounting the entire codebase as a volume when started
using docker-compose.
Note: a dependency of webmock (dev builds only) got updated to the point
of only supporting ruby 2.3 and above. So I locked it down to the last
version that supported ruby 2.1. The dependency tree was:
webmock was resolved to 1.24.6, which depends on
addressable was resolved to 2.7.0, which depends on
public_suffix was resolved to 4.0.1
Also, stop supporting a local dev. All dev should be done with the
container. Removed Gemfile.lock for the docker build so that everything
inside is the same as outside and it's like you're just developing
locally with the Docker container acting as the web-server.
|
Fixed up that last bit. It was just specifying a specific version of a gem that was only used in the dev build (not prod) so based on my testing I'm just going to merge this instead of asking for another review @StetsenTech |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the services onto a common network shared by all other apps.
Don't remove volumes on restart and rebuild. The dev can do that if
they need to b/c they want to nuke everything. We should rely on a
generally working env and not require nuking the volumes in the normal
dev flow. Use COPY instead of ADD b/c ADD wasn't doing what I thought it
was. COPY is recommended and volumes are mounted through the
docker-compose.yml file so that changes to files inside and outside the
container are reflected in both places.
TESTING