fixed pathencode to support '(' ')' characters #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isn't your PR handling the missing reserved characters already? What other changes are you thinking? Otherwise I think that PR is OK for me. |
benoitc
approved these changes
Jan 10, 2019
|
similar to #251 |
benoitc
requested changes
Jan 10, 2019
benoitc
approved these changes
Jan 15, 2019
|
@idod thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #550
After checking the RFC section 2.2, Reserved Characters, sub-delims, it seems that url path with '(' ')' characters is valid and should not be encoded.
I would like to do the same for the other characters as well, and do a small refactor that will reflect the RFC.
What do you think?
Cheers