feat: separate browser notification from ping sound in plugin settings #69
+550
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR separates the previous
pingSoundEnabledwhich controlled the browser notification as well into the 2 settings:pingSoundEnabled: Same name, different feature - It controls only the ping sound;browserNotificationEnabled: Now, this flag controls the browser notification;One other important change is: the ping sound comes enabled by default while the browser notification doesn't.
Motivation
For the browser notification to appear, it needs to ask for permission from the browser, which is not the ideal for every user - it can cause the person to question their privacy while using BBB. Despite that inconvenience, it's good to maintain the ping sound.
A good solution, then, is to separate the flag to enable the ping sound from the flag to enable the browser notification.
More
This PR depends on the recent refactor from #68.