fix(config): disable jsx-a11y/no-onchange #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
approved these changes
Jul 6, 2021
icatalina
reviewed
Jul 6, 2021
Comment on lines
+14
to
+15
| // Remove when https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/pull/757 gets released | ||
| 'jsx-a11y/no-onchange': 'off', |
There was a problem hiding this comment.
iirc eslint will complain with a non existing rule...
There was a problem hiding this comment.
The rule still exists, just got deprecated from the recommended config.
There was a problem hiding this comment.
I meant when they delete the rule, will find out... not sure we needed the coment 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule has been deprecated and removed from the
recommendedrules on jsx-eslint/eslint-plugin-jsx-a11y#757.More context on: jsx-eslint/eslint-plugin-jsx-a11y#398
Left a comment to remove it once it gets released.