-
Notifications
You must be signed in to change notification settings - Fork 315
Add Google Cloud documentation #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91f8390
to
e6af763
Compare
e6af763
to
9f3db80
Compare
Can one of the admins verify this patch? |
Jenkins, test this please. |
transformAlignments \ | ||
gs://my_bucket/my_reads.adam \ | ||
gs://my_bucket/my_new_reads.adam \ | ||
--jars google-cloud-nio-0.22.0-alpha-shaded.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this jar is in Maven Central, would --packages
be more appropriate? Note also we have an issue with adam-shell
that prevents using --jars
(#1349).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 towards using --packages
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you address @heuermh's comment RE: --packages
. Thanks for the added documentation, @Georgehe4!
Adding the dependency via --packages would be ideal except that the NIO file readers rely on Guava 20.0+. hadoop 2.6+ breaks with guava 17.0+ ( Line 600 in 49cbdb7
So I am using the shaded jar is the only way to prevent naming conflicts. I don't believe we can shade using the --packages flag, but let me know if anyone knows of a workaround. |
To clarify, the error that pops up when using --packages is: https://gist.github.com/Georgehe4/2897f2ead685a9fcf014cbf01cee4375. |
Running with --jars solves the above issue: |
Thanks for the detailed reply and gists @Georgehe4! It looks like |
|
Thank you, @Georgehe4 |
No description provided.