feat(behavior): descend with goalie on block/role-position #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texhnolyze
force-pushed
the
feature/goalie-behavior-descend
branch
8 times, most recently
from
632cfe9 to
ac08594
Compare
|
Is this still a draft or ready for review? @texhnolyze |
|
Ping @texhnolyze |
by creating a generalized cancelable `AbstractDynupAnimation` class, where each implementing class has to define a `reset_animation` method, which is triggered on pop. `GetWalkready` is also now using this as a base in our behavior. In the future this class should be merge with the similar `PlayAnimationDynup` class in HCM. We now descend as goalie both on our role position and when we are in the block position, which is handled by the `OnBlockPosition` decision.
texhnolyze
force-pushed
the
feature/goalie-behavior-descend
branch
from
b390a01 to
c9d75af
Compare
|
This is still up to date, but requiress some more testing and has a few todos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by creating a generalized cancelable
AbstractDynupAnimationclass,where each implementing class has to define a
reset_animationmethod,which is triggered on pop
GetWalkreadyis also now using this as a base in our behavior.In the future this class should be merge with the similar
PlayAnimationDynupclass in HCM.Checklist
colcon build