refactor: Enable and fix PyLint rules C0305 (trailing-newlines), C0324 (superfluous-parens), C0410 (multiple-imports), E0213 (no-self-argument) #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
requested changes
Jun 15, 2024
There was a problem hiding this comment.
Hello Ayush,
thank you again for your contribution and taking the time to improve Back In Time. We appreciate it.
Just add some minor suggestions.
Can you also add an entry to the CHANGES file please.
* Build: Enable PyLint rules C0305 (trailing-newlines), C0324 (superfluous-parens), C0410 (multiple-imports), E0213 (no-self-argument)
And if you want you could also sort the enabled error codes in the two test_lint.py files in their lexicographical order.
Best,
Christian
buhtz
changed the title
buhtz
added
the
PR: Modifications requested
Done |
|
All messages have been replied |
buhtz
approved these changes
Jun 15, 2024
buhtz
added
PR: Merge after creative-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the pylint errors for
'C0305', # trailing-newlines
'C0324', # superfluous-parens
'C0410', # multiple-imports
'E0213', # no-self-argument