tests: update ecdsa_secp256k1_sha256_bitcoin_test.json #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemenation -> implementation
|
This has been fixed upstream in C2SP/wycheproof#91 along with other changes. We should probably just reimport the file from upstream. |
|
The only other change is C2SP/wycheproof@875f85e , see https://github.com/C2SP/wycheproof/commits/master/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json . @eltociear Can you include this in the PR here? |
|
We should also update these lines then: secp256k1/src/wycheproof/WYCHEPROOF_COPYING Lines 1 to 4 in 8deef00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemenation -> implementation