fix: Add missing link to Value Overflow Incident in BIP-0099 #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
While the Value Overflow Incident fits "one of the chains rapidly disapears" it’s not clear to me that it would fit the description of a "non_proportional_inflatacoin_fork". Given that this BIP was proposed ten years ago and rejected five years ago, I’m not sure how often it still gets read, and it doesn’t seem worth bothering the author about whether that’s what they meant.
I’m not convinced this change is worth pursuing further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proper link to the Value Overflow Incident (August 2010) that created 184 billion BTC due to integer overflow, which was subsequently fixed through a controlled fork.
Resolves the TODO on line 347.