Skip to content

Compatibility: Add RBF data conditionals to templates #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bitschmidty
Copy link
Contributor

  • Handle missing RBF data in compatibility files in the list template
  • Handle missing RBF data in compatibility files in the details template

For background see: #257

@jnewbery jnewbery added the compatibility Enhancements or bugs for the compatibility matrix label Nov 7, 2019
@harding
Copy link
Collaborator

harding commented Nov 8, 2019

Tested ACK a1efec5

I think this could squashed down to one commit, but I'm fine with it as two commits. Tested by ensuring this change by itself only produces whitespace changes in the rendered HTML:

diff -ruNw _site/ _new_site/ | colordiff | less -R

Then I edited one of the compat data files to delete the RBF section and used make preview to make sure it worked and rendered the way I expected, and then plain make to ensure it passed all the regular tests.

@jnewbery jnewbery force-pushed the 2019-11-compatibility-rbf-data-conditions branch from a1efec5 to a9b4744 Compare November 8, 2019 20:17
@jnewbery
Copy link
Contributor

jnewbery commented Nov 8, 2019

Squashed commits (a1efec5 -> a9b4744)

@jnewbery jnewbery merged commit ce25b39 into bitcoinops:master Nov 8, 2019
@jnewbery
Copy link
Contributor

jnewbery commented Nov 8, 2019

Thanks for code @bitschmidty and review @harding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Enhancements or bugs for the compatibility matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants