-
Notifications
You must be signed in to change notification settings - Fork 702
FSDP2 integration: torch.chunks(Params4bit) #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can i get a feed back on this :) |
Hey @ved1beta, Thanks for the contribution. Could you tell us a bit more on why you deleted the lines that you deleted and how you validated your implementation? |
When changing from torch.nn.Parameter to torch.Tensor, we're now using the parent class's initialization methods which already handle basic tensor properties. |
Really cool, ultimately a high-level test making sure we also notice when this functionality breaks would be really cool. For now to reproduce your exact results it would already be helpful to include an example script in |
@ved1beta Just wondering why you closed this? |
I was stuck, examples and tests were failing can you help me with it i amwilling to make it work |
Fix Params4bit tensor subclass handling
Fix FSDP2 integration: torch.chunks(Params4bit) not returning Params4bit subclass #1424