Update SDK to 1.0.0-3005-5a722fd2 #5860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bw-ghapp[bot]](https://avatars.githubusercontent.com/u/15990069?s=60&v=4){kind=small}
bw-ghapp
bot
added
automated-pr
bw-ghapp
bot
requested review from
brian-livefront,
david-livefront and
a team
as code owners
bw-ghapp
bot
added
automated-pr
|
Great job! No new security vulnerabilities introduced in this pull request |
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
bw-ghapp
bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5860 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 703 703
Lines 53296 53296
Branches 7339 7339
=======================================
Hits 44878 44878
Misses 5826 5826
Partials 2592 2592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vvolkgang
reviewed
Sep 16, 2025
| userHandle: String = "mockUserHandle-$number", | ||
| userName: String = "mockUserName-$number", | ||
| userDisplayName: String = "mockUserDisplayName-$number", | ||
| counter: String = "0", |
There was a problem hiding this comment.
🤔 I'm assuming we're not converting this to int and just sending it to the RP.
vvolkgang
previously approved these changes
Sep 16, 2025
SaintPatrck
reviewed
Sep 16, 2025
| userHandle: String = "mockUserHandle-$number", | ||
| userName: String = "mockUserName-$number", | ||
| userDisplayName: String = "mockUserDisplayName-$number", | ||
| counter: String = "0", |
There was a problem hiding this comment.
Can we change this to parameter to hasCounter and assign counter = if (hasCounter) "$number" else "0"?
SaintPatrck
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK version from
1.0.0-2944-8447df0ctocom.bitwarden:sdk-android 1.0.0-3005-5a722fd2What's Changed
Raw changelog