Updating SDK to 8b605c5 (1.0.0-2301-0b6d9c4) #1928
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bw-ghapp[bot]](https://avatars.githubusercontent.com/u/15990069?s=60&v=4){kind=small}
bw-ghapp
bot
added
t:ci
|
Great job! No new security vulnerabilities introduced in this pull request |
vvolkgang
added a commit
to bitwarden/sdk-internal
that referenced
this pull request
Sep 16, 2025
…#439) ## 🎟️ Tracking PM-20288 ## 📔 Objective The initial goal was to trigger an iOS repo SDK update when sdk-internal `main` is updated, implementing that led to hard to maintain duplicate steps that were also slowing down the whole process even further, ended up refactoring multiple bits that would be hard to review independently. My suggestion for reviewers is to go through it as a new file instead of change-by-change. With that, here's a summary of updates: ### Structural 1. Consolidated jobs into a single one to reduce duplicate steps 1. Removed duplicated / unused steps like retrieving secrets, retrieving a run-id if missing, downloading BitwardenFFI file 1. Use the new BW App pattern for github authentication - still using the devops bot for commit signing 1. Removed swiftformat clone and build - took 50-60% of the average runtime just to format [Package.swift](https://github.com/bitwarden/sdk-internal/blob/main/crates/bitwarden-uniffi/swift/Package.swift) on each run, we should instead format it in this repo once. 1. Moved inline github template variables to env vars to mitigate script injections 1. Following @mandreko-bitwarden pro-tip, ran zizmor and addressed feedback like `persist-credentials: false` on `action/checkout` when we just need to checkout the repo 1. Update crazy-max/ghaction-import-gpg to 6.3.0 ## Functional 1. Average runtime reduced from 4m45s to 1m10s. 3. Triggers an iOS SDK update when new sdk-internal PRs are merged to `main` 4. Updates the sdk-swift commit message with additional sdk-internal info using [GitHub Autolink ](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls) patterns, enabling ios devs to quickly go to the original commit or PR. [screenshot#1] 5. Added step logs and quick links to the Action Summary [screenshot#2] 6. Sets `run-as` to communicate the Build we're releasing. [screenshot#3 - old vs new] 7. Branch Name input added to enable testing and set us up to support publishing feature branches in the future, like we've been doing for [Android](https://github.com/bitwarden/sdk-internal/packages/2591890), enabling quick feature branch testing. Test Run: * https://github.com/bitwarden/sdk-internal/actions/runs/17655035226 * triggered -> https://github.com/bitwarden/ios/actions/runs/17655061169 * opened -> bitwarden/ios#1928 [screenshot#1 - sdk-swift new commit message format] <img width="823" height="101" alt="image" src="https://github.com/user-attachments/assets/25aa2668-123f-46a2-9470-e3be2c4c94ab" /> [screenshot#2 - Action Summary] <img width="568" height="322" alt="image" src="https://github.com/user-attachments/assets/796589b4-0897-4952-a15a-1cf756395380" /> [screenshot#3 - Action `run-as`] <img width="447" height="151" alt="image" src="https://github.com/user-attachments/assets/f6bf1872-61c3-406b-9840-7a0c22154d0d" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK from
730c5b9c07bc4980ec13982594ba79b28f38d19bto8b605c51de8566878d22fbda609dd7ab9d265fe5What's Changed
Raw changelog