Skip to content

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented Oct 7, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

📔 Objective

This consolidates BitwardenField, SettingsMenuField, SettingsListItem, BitwardenBadge, and SettingsPickerField to BitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates the components in BWA.

📸 Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-06 at 14 57 56 Simulator Screenshot - iPhone 17 Pro - 2025-10-07 at 15 17 54

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Logo
Checkmarx One – Scan Summary & Details070d5b8a-7f63-4379-b2e4-7aa90d5addba

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 94.91525% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.82%. Comparing base (4d1dca1) to head (09dc40f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...d/UI/Platform/Settings/Settings/SettingsView.swift 96.00% 2 Missing ⚠️
...atform/Application/Views/SettingsPickerField.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
- Coverage   81.33%   75.82%   -5.51%     
==========================================
  Files         831     1013     +182     
  Lines       52439    61792    +9353     
==========================================
+ Hits        42651    46854    +4203     
- Misses       9788    14938    +5150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review October 7, 2025 21:42
@KatherineInCode KatherineInCode requested review from a team and matt-livefront as code owners October 7, 2025 21:42
@KatherineInCode KatherineInCode merged commit 9a9c578 into main Oct 9, 2025
13 of 14 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/various-components branch October 9, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants