Skip to content

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 8, 2025

🎟️ Tracking

PM-23279

📔 Objective

After a KDF update, it's possible for a user to have separate KDF settings for auth and master password unlock. If a user has master password unlock data, those KDF settings should be used when unlocking the vault with a master password.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner October 8, 2025 20:06
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Logo
Checkmarx One – Scan Summary & Details321f9b0a-4f0a-4629-b81a-166121771fb2

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.36%. Comparing base (4376077) to head (e666ab0).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2027   +/-   ##
=======================================
  Coverage   81.35%   81.36%           
=======================================
  Files         831      831           
  Lines       52483    52492    +9     
=======================================
+ Hits        42697    42708   +11     
+ Misses       9786     9784    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit b3c8367 into main Oct 13, 2025
10 checks passed
@matt-livefront matt-livefront deleted the matt/PM-23279-unlock-mp-unlock-data branch October 13, 2025 15:53
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants