Skip to content

[PM-20361] Expose signing key generation to mobile and wasm clients & add to key context #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 155 commits into from
May 21, 2025

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Apr 30, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20361

📔 Objective

Adds signing keys to the key context, and adds functions to make signature keys to the sdk.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as ready for review May 21, 2025 08:52
@quexten quexten requested a review from a team as a code owner May 21, 2025 08:52
@quexten quexten requested a review from justindbaur May 21, 2025 08:52
@quexten quexten merged commit e1642b6 into km/cose-signatures May 21, 2025
32 of 34 checks passed
@quexten quexten deleted the km/expose-signing-functions branch May 21, 2025 08:52
@quexten
Copy link
Contributor Author

quexten commented May 21, 2025

Consolidating to one PR

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant