Skip to content

Add functions for interval based secret loading #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tangowithfoxtrot
Copy link
Contributor

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented May 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsbca0ea91-6d72-4016-ad1c-c64fe5ae1db1

Great job, no security vulnerabilities found in this Pull Request

@tangowithfoxtrot tangowithfoxtrot force-pushed the add-functions-for-interval-based-secret-loading branch from e154495 to 6b0dd9b Compare May 2, 2025 17:40
Copy link

sonarqubecloud bot commented May 2, 2025

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 66.61%. Comparing base (8014451) to head (6b0dd9b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
bitwarden_license/bitwarden-sm/src/secrets/get.rs 0.00% 47 Missing ⚠️
...twarden_license/bitwarden-sm/src/client_secrets.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   66.81%   66.61%   -0.20%     
==========================================
  Files         213      213              
  Lines       15922    15979      +57     
==========================================
+ Hits        10638    10645       +7     
- Misses       5284     5334      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant