Refactor: Use serde instead of TryFrom<Vec<u8>> traits in IPC

[coroiu]

🎟️ Tracking

📔 Objective

Refactoring the IPC to use serde instead. Putting this in a separate PR to make reviewing easier

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – e3d519f8-5981-4a81-a504-90e87f9b42d7

Great job, no security vulnerabilities found in this Pull Request

[codecov]

Codecov Report

Attention: Patch coverage is 91.22807% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.61%. Comparing base (4de8897) to head (eb5d363).
Report is 1 commits behind head on PM-18042-build-request-response-structure.

Files with missing lines	Patch %	Lines
crates/bitwarden-ipc/src/rpc/exec/handler.rs	33.33%	6 Missing ⚠️
crates/bitwarden-ipc/src/rpc/error.rs	0.00%	2 Missing ⚠️
crates/bitwarden-ipc/src/ipc_client.rs	97.82%	1 Missing ⚠️
crates/bitwarden-ipc/src/message.rs	83.33%	1 Missing ⚠️

Additional details and impacted files

@@                              Coverage Diff                              @@
##           PM-18042-build-request-response-structure     #316      +/-   ##
=============================================================================
- Coverage                                      72.01%   70.61%   -1.40%     
=============================================================================
  Files                                            231      222       -9     
  Lines                                          18796    17356    -1440     
=============================================================================
- Hits                                           13536    12256    -1280     
+ Misses                                          5260     5100     -160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dani-garcia]

Looks pretty good to me, erased serde seems to have improved the generic bounds of this a lot. I only have some small nits here and there.

I wonder why rust doesn't seem able to correctly guess the error types in all the .try_into().map_err() functions, that's annoying.

[dani-garcia]

Same for this error:

                .map_err(|e: serde_utils::SerializeError| HandleError::Serialize(e.to_string()))?;

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud