Skip to content

[BRE-848] Add Workflow Permissions #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pixman20
Copy link
Contributor

@pixman20 pixman20 commented Jun 18, 2025

🎟️ Tracking

BRE-848

📔 Objective

Adding permissions to all workflows not being updated by BRE-831
This will prepare for changing the org wide GitHub actions setting to contents:read and packages:read as the default permissions provided to workflows.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@pixman20 pixman20 requested review from a team as code owners June 18, 2025 22:02
@pixman20 pixman20 requested a review from addisonbeck June 18, 2025 22:02
@pixman20 pixman20 self-assigned this Jun 18, 2025
@pixman20 pixman20 requested a review from michalchecinski June 18, 2025 22:02
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Logo
Checkmarx One – Scan Summary & Details05bd1ce3-035d-4354-8a9f-1aa6f6dc9366

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (c9bd7f9) to head (0e31cb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   71.76%   71.75%   -0.01%     
==========================================
  Files         224      224              
  Lines       18384    18385       +1     
==========================================
  Hits        13193    13193              
- Misses       5191     5192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addisonbeck
addisonbeck previously approved these changes Jun 19, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants