Skip to content

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Jun 19, 2025

🎟️ Tracking

📔 Objective

The mobile clients will call init_crypto multiple times on the same client if the user types the wrong password/pin.

The simplest fix here is to make it so that init_user_id only errors when there is an attempted UUID change, and trying to set the same UUID is just ignored. The UUID will only be set the very first call either way.

Ideally we'd do as mentioned in #278, and just provide this ID during initialization once we have a pure/user-bound client split, but that's a bigger API break.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Verified

This commit was signed with the committer’s verified signature.
dani-garcia Daniel García
Copy link
Contributor

github-actions bot commented Jun 19, 2025

Logo
Checkmarx One – Scan Summary & Detailscb44aaa3-d396-44b4-b9ae-f0014b673b0f

Great job, no security vulnerabilities found in this Pull Request

Verified

This commit was signed with the committer’s verified signature.
dani-garcia Daniel García
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (17866c0) to head (fc65f4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   71.75%   71.78%   +0.02%     
==========================================
  Files         224      224              
  Lines       18385    18403      +18     
==========================================
+ Hits        13193    13211      +18     
  Misses       5192     5192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia marked this pull request as ready for review June 19, 2025 17:07
@dani-garcia dani-garcia requested a review from a team as a code owner June 19, 2025 17:07
@dani-garcia dani-garcia requested a review from coroiu June 19, 2025 17:07
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever fix 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

@dani-garcia dani-garcia merged commit 3293cc7 into main Jun 23, 2025
43 checks passed
@dani-garcia dani-garcia deleted the ps/ignore-init-user-same-id branch June 23, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants