Skip to content

PM-23639: Add CXF Import sample #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PM-23639: Add CXF Import sample #361

wants to merge 2 commits into from

Conversation

abergs
Copy link
Member

@abergs abergs commented Jul 25, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23639

📔 Objective

This PR adds the CXF sample from the repo so that we can use it for reference.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@abergs abergs requested a review from a team as a code owner July 25, 2025 08:44
@abergs abergs requested review from addisonbeck, Hinton and dani-garcia and removed request for addisonbeck July 25, 2025 08:44
Copy link
Contributor

github-actions bot commented Jul 25, 2025

Logo
Checkmarx One – Scan Summary & Details62144745-4ca0-42a6-bfcd-6591ceb1806c

Great job, no security vulnerabilities found in this Pull Request

@abergs
Copy link
Member Author

abergs commented Jul 25, 2025

How do I tell Sonar to relax?

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (9f58e91) to head (6f91f2d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-exporters/src/cxf/import.rs 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   73.26%   73.27%   +0.01%     
==========================================
  Files         248      248              
  Lines       20823    20848      +25     
==========================================
+ Hits        15255    15277      +22     
- Misses       5568     5571       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant