[PM-22256] - Updating OpenAPI bindings #366
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 73.43% 73.62% +0.18%
==========================================
Files 248 248
Lines 20962 20912 -50
==========================================
+ Hits 15393 15396 +3
+ Misses 5569 5516 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
On first look everything looks good to me. Deleting register and keeping the match sounds reasonable, that code will need to be rewritten to use the new endpoints.
Can you include the git commit of the server that was used to generate the bindings? It would make it much faster for me to review the generated code that way.
| @@ -178,32 +177,6 @@ async fn process_commands() -> Result<()> { | |||
| } | |||
| return Ok(()); | |||
| } | |||
| Commands::Register { | |||
There was a problem hiding this comment.
Clippy is complaining about the single branch match, you can do two things here:
- Keep the branch, but don't do anything:
Commands::Register { .. } => unimplemented!(),- Silence the warning on top of the match:
#[allow(clippy::single_match)]
match command.clone() {
I added the commit to the description. |
|
🎟️ Tracking
PM-22256
📔 Objective
As a part of adding new properties to the collection structs, the API bindings need to be regenerated to include the new changes.
These bindings were generated off this commit I believe.
bitwarden/server@a84e555
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes