Skip to content

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Aug 28, 2025

🎟️ Tracking

📔 Objective

Wraps up the b64 migration.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners August 28, 2025 09:26
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Logo
Checkmarx One – Scan Summary & Detailsf513d986-95f6-43ff-bf25-838824273d03

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 69.56522% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.88%. Comparing base (8a7175f) to head (9b6b400).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-fido/src/lib.rs 18.18% 9 Missing ⚠️
crates/bitwarden-fido/src/types.rs 0.00% 4 Missing ⚠️
crates/bitwarden-encoding/src/b64.rs 0.00% 3 Missing ⚠️
crates/bitwarden-encoding/src/b64url.rs 0.00% 3 Missing ⚠️
crates/bitwarden-core/src/key_management/crypto.rs 0.00% 1 Missing ⚠️
...crypto/src/safe/password_protected_key_envelope.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   76.75%   76.88%   +0.13%     
==========================================
  Files         270      270              
  Lines       25664    25574      -90     
==========================================
- Hits        19698    19663      -35     
+ Misses       5966     5911      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 requested review from dani-garcia and removed request for justindbaur September 5, 2025 23:38
dani-garcia
dani-garcia previously approved these changes Sep 8, 2025
Copy link

Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KM looks good

Copy link
Contributor

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vault changes look good

@Hinton Hinton merged commit fa0e024 into main Sep 15, 2025
51 checks passed
@Hinton Hinton deleted the arch/more-b64 branch September 15, 2025 15:33
gbubemismith pushed a commit that referenced this pull request Sep 16, 2025
Wraps up the b64 migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants