-
Notifications
You must be signed in to change notification settings - Fork 20
Update sdk-internal CODEOWNERS to give more team ownership #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❓ @withinfocus @Hinton |
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
=======================================
Coverage 78.10% 78.10%
=======================================
Files 283 283
Lines 27628 27628
=======================================
Hits 21579 21579
Misses 6049 6049 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/CODEOWNERS
Outdated
# BW CLI | ||
crates/bw/src/admin_console/** @bitwarden/team-admin-console-dev @bitwarden/team-platform-dev | ||
crates/bw/src/auth/** @bitwarden/team-auth-dev @bitwarden/team-platform-dev | ||
crates/bw/src/tools/** @bitwarden/team-tools-dev @bitwarden/team-platform-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tools doesn't currently own any code on the SDK, so not sure we should be adding them to the CLI yet, not until they own the bitwarden-generators
crate themselves at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Would you say the same for Admin Console?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I thought that AC was already partially owning the collections crate as the AC team had put some work on it, seems like I imagined it.
Yeah I think both tools and AC should be left out of the CLI until they own the crates that are used by the CLI. Once they are ready to own those, we can add them to the CLI too.
|
…: Update sdk-internal CODEOWNERS to give more team ownership (bitwarden/sdk-internal#495)
📔 Objective
Makes several changes to
CODEOWNERS
to reflect maturity insdk-internal
code ownership and clarity of ownership definitions:bitwarden-vault
crate fromteam-platform-dev
toteam-sdk-sme
.bw
CLI folders, with all except Vault usingteam-platform-dev
and Vault usingteam-sdk-sme
, reflecting the change in item 1 above.bitwarden-crypto
to be grouped with the other joint team-owned crates, as it felt the same as the others (currently shared, with a goal of team-owned), and therefore was OK to group together.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes