Skip to content

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Oct 7, 2025

📔 Objective

Makes several changes to CODEOWNERS to reflect maturity in sdk-internal code ownership and clarity of ownership definitions:

  1. Changed joint ownership of the bitwarden-vault crate from team-platform-dev to team-sdk-sme.
  2. Added non-Platform co-owners for all bw CLI folders, with all except Vault using team-platform-dev and Vault using team-sdk-sme, reflecting the change in item 1 above.
  3. Moved bitwarden-crypto to be grouped with the other joint team-owned crates, as it felt the same as the others (currently shared, with a goal of team-owned), and therefore was OK to group together.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Updated SDK ownership Updated sdk-internal ownership Oct 7, 2025
@trmartin4 trmartin4 marked this pull request as ready for review October 7, 2025 00:13
@trmartin4 trmartin4 requested a review from a team as a code owner October 7, 2025 00:13
@trmartin4 trmartin4 requested review from coroiu and dereknance October 7, 2025 00:13
@trmartin4
Copy link
Member Author

trmartin4 commented Oct 7, 2025

@withinfocus @Hinton bitwarden-crypto seems like an outlier here, which includes dept-architecture. is there a reason why it needs to be special? Could this be team-sdk-sme instead?

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsf5599816-0b8b-4a06-bea5-2c745a40b85c

Great job! No new security vulnerabilities introduced in this pull request

@trmartin4 trmartin4 changed the title Updated sdk-internal ownership Update sdk-internal CODEOWNERS to give more team ownership Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (ae9b8b5) to head (bf555fa).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files         283      283           
  Lines       27628    27628           
=======================================
  Hits        21579    21579           
  Misses       6049     6049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coroiu
coroiu previously approved these changes Oct 7, 2025
# BW CLI
crates/bw/src/admin_console/** @bitwarden/team-admin-console-dev @bitwarden/team-platform-dev
crates/bw/src/auth/** @bitwarden/team-auth-dev @bitwarden/team-platform-dev
crates/bw/src/tools/** @bitwarden/team-tools-dev @bitwarden/team-platform-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools doesn't currently own any code on the SDK, so not sure we should be adding them to the CLI yet, not until they own the bitwarden-generators crate themselves at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Would you say the same for Admin Console?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I thought that AC was already partially owning the collections crate as the AC team had put some work on it, seems like I imagined it.

Yeah I think both tools and AC should be left out of the CLI until they own the crates that are used by the CLI. Once they are ready to own those, we can add them to the CLI too.

dereknance
dereknance previously approved these changes Oct 7, 2025
@trmartin4 trmartin4 dismissed stale reviews from dereknance and coroiu via bf555fa October 7, 2025 14:10
@trmartin4 trmartin4 requested a review from dani-garcia October 7, 2025 14:10
Copy link

sonarqubecloud bot commented Oct 7, 2025

@trmartin4 trmartin4 merged commit a2c20d1 into main Oct 7, 2025
50 checks passed
@trmartin4 trmartin4 deleted the update-ownership branch October 7, 2025 14:37
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 7, 2025
…: Update sdk-internal CODEOWNERS to give more team ownership (bitwarden/sdk-internal#495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants