-
Notifications
You must be signed in to change notification settings - Fork 16
Bump up num-complex to 0.3.1 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cargo.toml
Outdated
@@ -17,12 +17,12 @@ categories = ["api-bindings", "science"] | |||
keywords = ["linear-algebra"] | |||
|
|||
[dependencies] | |||
libc = "0.2" | |||
libc = "0.2.84" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
Cargo.toml
Outdated
|
||
[dependencies.num-complex] | ||
version = "0.2" | ||
version = "0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to drop .1
, or is there a reason to keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed indeed since this crate works with num-complex 0.3.0. If you actually want to support all "0.3.x" versions of num-complex and other crates, I will drop all patch versions.
IMO, version specification without patch version, num-complex = "0.3"
in this case, means this crate works with all versions of num-complex 0.3.x
, but it is generally too strict requirements comparing that num-complex = "0.3.1"
means this crate works with num-complex 0.3.x
where x >= 1
. We usually test these crates with latest dependent crates, and cargo users can get latest crates easily. Thus I encourage to use full version specification like "0.3.1" always to avoid mysterious broken Cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rely on semantic versioning here. Before version 1.0, there are no real promises, but people usually follow the convention that patch versions are backward compatible. Specifying a patch version is unnecessary constraint, which one would not want to have unless one knows that something new was added, and that something new is needed. I would stop at minor versions in all dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I will remove them.
Cargo.toml
Outdated
default-features = false | ||
|
||
[dependencies.blas-sys] | ||
version = "0.7" | ||
version = "0.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
Uh oh!
There was an error while loading. Please reload this page.