Remove ES2023 target from Array.findLast() PR #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-basov
changed the title
m-basov
changed the title
Signed-off-by: mbasov2 <[email protected]>
m-basov
force-pushed
the
array-find-last
branch
from
c1ae44e to
7d8abb9
Compare
acutmore
approved these changes
Aug 25, 2022
m-basov
added a commit
that referenced
this pull request
Aug 31, 2022
Signed-off-by: mbasov2 <[email protected]>
m-basov
added a commit
that referenced
this pull request
Dec 16, 2022
* Add .findLast(), .findLastIndex(), and es2023 target Signed-off-by: mbasov2 <[email protected]> * Update baselines Signed-off-by: mbasov2 <[email protected]> Remove ES2023 target (#75) Signed-off-by: mbasov2 <[email protected]>
m-basov
added a commit
that referenced
this pull request
Jan 13, 2023
* Add .findLast(), .findLastIndex(), and es2023 target Signed-off-by: mbasov2 <[email protected]> * Update baselines Signed-off-by: mbasov2 <[email protected]> Remove ES2023 target (#75) Signed-off-by: mbasov2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove ES2023 target (requested in microsoft#49636 (comment)) but leave ES2023 lib.
Also, added test cases for non-numbers.
Testing performed
✔
node built/local/tsc --noEmit --moduleResolution node --lib es2023 --target es2022 tests/cases/compiler/findLast.ts✔
node built/local/tsc --noEmit --moduleResolution node --lib esnext --target es2022 tests/cases/compiler/findLast.ts✔
node built/local/tsc --noEmit --moduleResolution node --target esnext tests/cases/compiler/findLast.ts❌
node built/local/tsc --noEmit --moduleResolution node --lib es2022 --target es2022 tests/cases/compiler/findLast.ts❌
node built/local/tsc --noEmit --moduleResolution node --target es2022 tests/cases/compiler/findLast.ts