Skip to content

Cannot read property 'color' of undefined #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denpatin opened this issue Jan 17, 2018 · 1 comment · Fixed by #5
Closed

Cannot read property 'color' of undefined #4

denpatin opened this issue Jan 17, 2018 · 1 comment · Fixed by #5

Comments

@denpatin
Copy link

The original issue comes from Gitea: go-gitea/gitea#3382

But still I'm duplicating the text:

Description

There're not so many branches that a currently simultaneously used (around 6-7), however the overall number of branches is 28. Something started to go wrong today then the git graph stopped to display correctly—there're no more colors at all. Below are the screenshots of the problem.

Unfortunately I really cannot give more info about the problem because our development process haven't changed for a long time: We just commit and push and very often review this git graph on out instance of Gitea. And out of the blue it gets white with an error in JS console.

My first assumption was that it may be connected with the fact than each new branch gets it own color, and maybe there's a finite number of colors to display, however 28 branches isn't a limit at all for a bit project... So I do believe the assumption is wrong.

Screenshots

The result of something goes wrong with git graph:

image

What the developer tools in Chrome outputs regarding the error:

image

The direct place in the JS file where the error occurs:

image

@denpatin
Copy link
Author

Perhaps important update.

After a new commit was added, the graph started to display entirely. However, when one more was added, is once again started to the crooked in the same way, directly to the same place as in the previous screenshot.

The regularity of this may be important: When the test branch is the very upper one, then this gets crooked; otherwise it works. So it isn't clear whether this relates to the number of total branches or still something else.

axifive added a commit to axifive/gitgraph.js that referenced this issue May 31, 2018
@bluef bluef closed this as completed in #5 Jun 1, 2018
bluef added a commit that referenced this issue Jun 1, 2018
Fix line break bug, aka 'Cannot read property 'color' of undefined' (#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant