-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Windows on ARM64 GitHub Actions CI support #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add Windows on ARM64 GitHub Actions CI support #1077
Conversation
@pdimov Thank you. |
Could you please remove the changes to .gitmodules and libs/context from this PR? |
Thank you for the response. The .gitmodules will definitely need to removed. But we need libs/context changes for the main ci.yml to build for windows arm64 . So first the changes in libs/context needs to be merged to develop2 (when approvers are happy). Without these changes ci.yml work flow with not succeed for windows on ARM64. Are you recommending create another PR for lib/context changes? I just created it boostorg/context#315 here. once this is accepted, I can remove the .gitmodules and libs/context changes from this PR , otherwise it may not build, when you enable/approve the work flow to build. Kindly advise how to progress. |
Fixes issue : boostorg/boost#1070 Related to PR: boostorg/boost#1077
The |
e2fff76
to
ea33625
Compare
Fixes issue : boostorg#1070 Draft PR for the review. .gitmodules changes were done to build in my fork. They will be discarded in the due course.
ea33625
to
25bb13d
Compare
@pdimov If I remove the .gitmodule and libs/context changes from this branch, how can we ensure that workflow is building correctly? So I thought,
Hope I make sense, If not , please correct me , if this needs to be done in a different way. These changes are tested by building in my fork and it was working without any issues. Thank you very much for your patience and help to push these changes. |
OK, I approved the workflow. |
@pdimov Can you please advice next step of action for me? Thank you. |
At this point we can only wait for the maintainer of Context to apply the PR. Maybe you could add Windows jobs to his CI to speed this up? I don't see Windows being tested there at the moment. |
@pdimov Thank you. |
When I rewrote ci.yml in Context, I probably didn't add Windows jobs because I was unable to make them pass in some reasonable amount of time so I gave up. The maintainer of Context is Oliver Kowalke. Line 38 in 009cb0e
|
I made a PR that adds Windows jobs to Context's ci.yml: boostorg/context#316 |
Currently we do not have fcontext related ASM files for Windows ARM64. So we can use winfib context-impl only for Windows ARM64. Fixes issue : boostorg/boost#1070 Related to PR: boostorg/boost#1077
Currently we do not have fcontext related ASM files for Windows ARM64. So we can use winfib context-impl only for Windows ARM64. Fixes issue : boostorg/boost#1070 Related to PR: boostorg/boost#1077
@pdimov Thank you. |
Currently we do not have fcontext related ASM files for Windows ARM64. So we can use winfib context-impl only for Windows ARM64. Fixes issue : boostorg/boost#1070 Related to PR: boostorg/boost#1077
Fixes issue : #1070
Draft PR for the review.
.gitmodules changes were done to build in my fork. They will be discarded in the due course.