Skip to content

Conversation

vask2108
Copy link

Fixes issue : #1070

Draft PR for the review.

.gitmodules changes were done to build in my fork. They will be discarded in the due course.

@vask2108
Copy link
Author

vask2108 commented Sep 3, 2025

@pdimov
I have raised this PR for Windows Arm64. Do you know who can review this PR? My intention is enabled Boost API for Windows ARM64 platform.

Thank you.

@pdimov
Copy link
Member

pdimov commented Sep 3, 2025

Could you please remove the changes to .gitmodules and libs/context from this PR?

@vask2108
Copy link
Author

vask2108 commented Sep 8, 2025

@pdimov

Thank you for the response.

The .gitmodules will definitely need to removed. But we need libs/context changes for the main ci.yml to build for windows arm64 . So first the changes in libs/context needs to be merged to develop2 (when approvers are happy). Without these changes ci.yml work flow with not succeed for windows on ARM64.

Are you recommending create another PR for lib/context changes?

I just created it boostorg/context#315 here. once this is accepted, I can remove the .gitmodules and libs/context changes from this PR , otherwise it may not build, when you enable/approve the work flow to build.

Kindly advise how to progress.
Thank you.

vask2108 added a commit to vask2108/context that referenced this pull request Sep 8, 2025
@pdimov
Copy link
Member

pdimov commented Sep 8, 2025

The libs/context submodule tracks the develop branch from https://github.com/boostorg/context and is updated automatically by a script. Even if we change it in the PR, the script will just roll back these changes because libs/context will no longer correspond to what's in the Context repo.

@vask2108 vask2108 force-pushed the feature/windows-arm64-gha-runner branch from e2fff76 to ea33625 Compare September 9, 2025 12:06
Fixes issue : boostorg#1070

Draft PR for the review.

.gitmodules changes were done to build in my fork. They will be discarded in the due course.
@vask2108 vask2108 force-pushed the feature/windows-arm64-gha-runner branch from ea33625 to 25bb13d Compare September 9, 2025 12:35
@vask2108
Copy link
Author

vask2108 commented Sep 9, 2025

@pdimov
Thank you for the response. Apologies, I have not fully understood unfortunately.

If I remove the .gitmodule and libs/context changes from this branch, how can we ensure that workflow is building correctly?
If you enable the above  "1 workflow awaiting approval" step, It will look for libs/context changes in the develop (if I am not wrong).
But my changes to libs/context are not merged yet to develop, so the build fails and it may not be possible to assess whether my changes are actually working or not. ( If I am not wrong)

So I thought,

  1. First check workflow passes with temporary .gitmodule changes and linking libs/context from my fork and maintainers are happy with the changes. 
  2. merge Add Windows ARM64 support context#315, which pushes libs/context changes into the develop branch.
  3. Later I need to update PR by removing temporary .gitmodule changes and removing libs/context as lib/context changes have gone into the develop now.
  4. merge this  PR with ci.yml changes only and It should build without any issue on the develop.

Hope I make sense, If not , please correct me , if this needs to be done in a different way.

These changes are tested by building in my fork and it was working without any issues.

Thank you very much for your patience and help to push these changes.

@pdimov
Copy link
Member

pdimov commented Sep 9, 2025

OK, I approved the workflow.

@vask2108
Copy link
Author

vask2108 commented Sep 9, 2025

@pdimov
Thank you.
I see almost all jobs (including new windows arm64) passing . But cmake-test-posix(ubuntu-latest) is failing, but it appears it not related to my changes to me.

Can you please advice next step of action for me?

Thank you.

@pdimov
Copy link
Member

pdimov commented Sep 9, 2025

At this point we can only wait for the maintainer of Context to apply the PR.

Maybe you could add Windows jobs to his CI to speed this up? I don't see Windows being tested there at the moment.

@vask2108
Copy link
Author

vask2108 commented Sep 9, 2025

@pdimov
Thank you. That's correct, there are no windows tests from libs/context CI. There must be some reason.
Do you know who the maintainer is? I chase them. In the meantime, I can also try and evaluate the writing windows ARM64 CI for libs/context.

Thank you.

@pdimov
Copy link
Member

pdimov commented Sep 9, 2025

When I rewrote ci.yml in Context, I probably didn't add Windows jobs because I was unable to make them pass in some reasonable amount of time so I gave up.

The maintainer of Context is Oliver Kowalke.

context Oliver Kowalke <oliver.kowalke -at- gmail.com>

@pdimov
Copy link
Member

pdimov commented Sep 9, 2025

I made a PR that adds Windows jobs to Context's ci.yml: boostorg/context#316

vask2108 added a commit to vask2108/context that referenced this pull request Sep 11, 2025
Currently we do not have fcontext related ASM files for Windows ARM64.
So we can use winfib context-impl only for Windows ARM64.

Fixes issue : boostorg/boost#1070
Related to PR: boostorg/boost#1077
vask2108 added a commit to vask2108/context that referenced this pull request Sep 11, 2025
Currently we do not have fcontext related ASM files for Windows ARM64.
So we can use winfib context-impl only for Windows ARM64.

Fixes issue : boostorg/boost#1070
Related to PR: boostorg/boost#1077
@vask2108
Copy link
Author

@pdimov
Thank you . I have taken changes from boostorg/context#316 and updated my PR boostorg/context#315 with Windows ARM64 and Windows ARM64 tests are passing now waiting for @olk to review it when possible.

Thank you.

vask2108 added a commit to vask2108/context that referenced this pull request Sep 11, 2025
Currently we do not have fcontext related ASM files for Windows ARM64.
So we can use winfib context-impl only for Windows ARM64.

Fixes issue : boostorg/boost#1070
Related to PR: boostorg/boost#1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants