Update minimum CMake version to 3.9 #1083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoostRoot uses `CMAKE_MATCH_<n>` which only exists since CMake 3.9
|
I wonder how did that work before. |
|
No one used CMake < 3.9 for the super build I guess. Or it just skipped stuff or added everything as the variable was unset |
|
@grisumbras reports that 3.8 works: boostorg/json#1110 |
|
Can we merge #1082 to verify the used CMake version? In this case: It is a documentation bug. That variables were supported since 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoostRoot uses
CMAKE_MATCH_<n>which only exists since CMake 3.9https://cmake.org/cmake/help/latest/command/if.html#matches
@pdimov