Skip to content

CMake boost super-build fixups for cmake-3.8 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
+16 −11
Merged

CMake boost super-build fixups for cmake-3.8 #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2edcd6
CMake 3.15 is required, 3.14 does not work
nigels-com Sep 6, 2025
fc2009f
CMake 3.14 is required (due to parser), 3.13 does not work
nigels-com Sep 10, 2025
fa1223a
CMake 3.12 required for Python3 BoostPrettyPrinters, CMake 3.8 now works
nigels-com Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,19 @@ if(BOOST_JSON_IS_ROOT)
unset(CMAKE_FOLDER)
endif()

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/pretty_printers")
find_package(BoostPrettyPrinters QUIET)
if(BoostPrettyPrinters_FOUND)
boost_pretty_printers_gdb_python_header(
TARGET boost_json_regenerate_printers
INPUT src/boost_json_gdb_printers.py
OUTPUT include/boost/json/detail/gdb_printers.hpp
HEADER_GUARD BOOST_JSON_DETAIL_GDB_PRINTERS_HPP
NO_DISABLE_MACRO
EXCLUDE_FROM_ALL)
if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.12.0")
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/pretty_printers")
# Note: find_package(Python3) supported in cmake-3.12 onwards
find_package(BoostPrettyPrinters QUIET)
if(BoostPrettyPrinters_FOUND)
boost_pretty_printers_gdb_python_header(
TARGET boost_json_regenerate_printers
INPUT src/boost_json_gdb_printers.py
OUTPUT include/boost/json/detail/gdb_printers.hpp
HEADER_GUARD BOOST_JSON_DETAIL_GDB_PRINTERS_HPP
NO_DISABLE_MACRO
EXCLUDE_FROM_ALL)
endif()
endif()

function(boost_json_setup_properties target)
Expand Down
4 changes: 3 additions & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ target_compile_definitions(boost_json-no_exceptions PRIVATE
BOOST_JSON_NO_LIB=1
)
target_compile_options(boost_json-no_exceptions PRIVATE
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-fno-exceptions>
$<$<CXX_COMPILER_ID:GNU>:-fno-exceptions>
$<$<CXX_COMPILER_ID:Clang>:-fno-exceptions>
$<$<CXX_COMPILER_ID:AppleClang>:-fno-exceptions>
$<$<CXX_COMPILER_ID:MSVC>:/wd4530>
$<$<CXX_COMPILER_ID:MSVC>:/wd4577>
)
Expand Down
Loading