Fixed module tests fail

[Kojoley]

Since recently lightweight_test introduced a sanitation to ensure that boost::report_errors() is called, and it does not in module tests.

The problem could be fixed by exporting the function and calling it from these python tests, but as it already done in other module tests I just turned those usages lightweight_test to a regular assertation.

ref #254

[stefanseefeld]

I don't think BOOST_ASSERT is a device meant to be used for testing. Notably, it will empty (and the enclosed expression won't be evaluated) if NDEBUG is defined, just like the standard assert macro.

[Kojoley]

Then fix it like you think it should be.

Also grep the tests for BOOST_ASSERT. https://github.com/boostorg/python/search?q=BOOST_ASSERT&unscoped_q=BOOST_ASSERT

The cases closely related to this PR:

python/test/virtual_functions.cpp

Lines 15 to 34 in ac62db1

	#include <boost/assert.hpp>
	using namespace boost::python;
	struct X
	{
	explicit X(int x) : x(x), magic(7654321) { ++counter; }
	X(X const& rhs) : x(rhs.x), magic(7654321) { ++counter; }
	virtual ~X() { BOOST_ASSERT(magic == 7654321); magic = 6666666; x = 9999; --counter; }
	void set(int _x) { BOOST_ASSERT(magic == 7654321); this->x = _x; }
	int value() const { BOOST_ASSERT(magic == 7654321); return x; }
	static int count() { return counter; }
	private:
	void operator=(X const&);
	private:
	int x;
	long magic;
	static int counter;
	};

python/test/back_reference.cpp

Lines 24 to 39 in ac62db1

	struct X
	{
	explicit X(int x) : x(x), magic(7654321) { ++counter; }
	X(X const& rhs) : x(rhs.x), magic(7654321) { ++counter; }
	virtual ~X() { BOOST_ASSERT(magic == 7654321); magic = 6666666; x = 9999; --counter; }
	void set(int _x) { BOOST_ASSERT(magic == 7654321); this->x = _x; }
	int value() const { BOOST_ASSERT(magic == 7654321); return x; }
	static int count() { return counter; }
	private:
	void operator=(X const&);
	private:
	int x;
	long magic;
	static int counter;
	};

python/test/callbacks.cpp

Lines 31 to 46 in ac62db1

	struct X
	{
	explicit X(int x) : x(x), magic(7654321) { ++counter; }
	X(X const& rhs) : x(rhs.x), magic(7654321) { ++counter; }
	~X() { BOOST_ASSERT(magic == 7654321); magic = 6666666; x = 9999; --counter; }
	void set(int _x) { BOOST_ASSERT(magic == 7654321); this->x = _x; }
	int value() const { BOOST_ASSERT(magic == 7654321); return x; }
	static int count() { return counter; }
	private:
	void operator=(X const&);
	private:
	int x;
	long magic;
	static int counter;
	};

[stefanseefeld]

OK, fair enough. I'll merge this in an attempt to "harmonize" our testing logic. Then we can open a new request to substitute boost_assert by something more robust and suitable for use with testing.