Include negated assertion_result messages: #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a helper function `isEqualCaseInsensitive()` returning helpful
detail in the resulting assertion_result message, negation of
that result in a `BOOST_CHECK()` results in that detail being
discarded.
This feature preserves that detail in the negated case.
For example:
`BOOST_CHECK(isEqualCaseInsensitive('z', 'Z'))` included detail like `[z
isEqualCaseInsensitiveTo Z]`
`BOOST_CHECK(!isEqualCaseInsensitive('z', 'Z'))` discarded that detail
until this revision, which now includes it: `NOT([z
isEqualCaseInsensitiveTo Z])`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a helper function
isEqualCaseInsensitive()returning helpful detail in theassertion_resultmessage, negation in aBOOST_CHECK()results in that detail being discarded.This feature preserves that detail in the negated case.
For example:
BOOST_CHECK(isEqualCaseInsensitive('z', 'Z'))included detail like[z isEqualCaseInsensitiveTo Z]BOOST_CHECK(!isEqualCaseInsensitive('z', 'Z'))discarded that detail until this revision, which now includes it:NOT([z isEqualCaseInsensitiveTo Z])