Rework API to use a Kubernetes CRD #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
k8s-prep
branch
2 times, most recently
from
2a225ee to
c23b6f6
Compare
cgwalters
force-pushed
the
k8s-prep
branch
3 times, most recently
from
0c4fda5 to
0535729
Compare
|
/retest |
I was working on the configmap support slowly, but a big issue it raised was how we expose the ability to mutate things. Our current "API" is just an imperative CLI. This would require higher level tooling to manage Kubernetes style declarative system state. Instead, let's use the really nice Rust `kube` crate to define a CRD; this is what is output (in YAML form) via `bootc status` now. We translate the imperative CLI verbs into changes to the `spec` field. However, things become more compelling when we offer a `bootc edit` CLI verb that allows arbitrary changes to the spec. I think this will become the *only* way to manage attached configmaps, instead of having imperative CLI verbs like `bootc configmap add` etc. At least to start. Signed-off-by: Colin Walters <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on the configmap support slowly, but a big issue
it raised was how we expose the ability to mutate things.
Our current "API" is just an imperative CLI. This would require
higher level tooling to manage Kubernetes style declarative system state.
Instead, let's use the really nice Rust
kubecrate to define a CRD;this is what is output (in YAML form) via
bootc statusnow.We translate the imperative CLI verbs into changes to the
specfield.
However, things become more compelling when we offer a
bootc editCLI verb that allows arbitrary changes to the spec.
I think this will become the only way to manage attached configmaps,
instead of having imperative CLI verbs like
bootc configmap addetc.At least to start.