hack: Rework+cleanup container build #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
rework-containerfile
branch
from
b9d533b to
a5c272b
Compare
Main motivation: I was looking at making more changes here - Use an idiom I'd like to standardize more of copy context to `FROM scratch` image which is then mounted and consumed in other phases by mounting. This helps avoid polluting later containers with intermediate copied files. - Change `build.sh` to handle being run from any directory - Drop the `dev-rootfs` stuff as it's weird and awkward; instead we should encourage multi-step builds deriving from this image - Don't make `bootc.tar.zst` only to immediately untar it; just use `COPY` from the build container - Use heredocs to condense multiple `RUN` invocations to avoid pointless small layers Signed-off-by: Colin Walters <[email protected]>
So we can use heredocs. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
rework-containerfile
branch
from
a5c272b to
d126574
Compare
Humm...very confused by this failure |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation: I was looking at making more changes here
FROM scratchimage which is then mounted and consumed in other phases by mounting. This helps avoid polluting later containers with intermediate copied files.build.shto handle being run from any directorydev-rootfsstuff as it's weird and awkward; instead we should encourage multi-step builds deriving from this imagebootc.tar.zstonly to immediately untar it; just useCOPYfrom the build containerRUNinvocations to avoid pointless small layers