packaging/rpm: Be sure we pull in chcon (and util-linux) #1391
Conversation
This version is unused. At one time I accidentally bumped it and then kept doing so occasionally. Fixate it so that doesn't happen again. The canonical version is in lib/Cargo.toml.
We execute it, and Anaconda was somehow omitting this. Also pull in util-linux-core because we also depend on that. bootc-dev#1383 (comment) Signed-off-by: Colin Walters <[email protected]>
cgwalters
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies for bootc. It adds chcon as a binary dependency and updates the RPM spec file accordingly. It also changes the version of the bootc CLI crate to a stub value, presumably to help centralize versioning in the library crate.
My review focuses on the consistency of the dependency declarations. I've found that the RPM spec file is missing some runtime dependencies that are declared elsewhere, and I've suggested a change to make it complete. The other changes look reasonable.
| Requires: util-linux-core | ||
| Requires: /usr/bin/chcon |
There was a problem hiding this comment.
Thanks for adding these dependencies. The new comment on lines 50-51 about keeping this in sync with workspace.metadata.binary-dependencies is very helpful.
Following that comment, I checked Cargo.toml and noticed zstd and systemctl are also listed as binary dependencies. To make the spec file fully consistent, we should probably add Requires for them as well. I've suggested adding file-path based Requires for them to be consistent with the addition of /usr/bin/chcon.
Requires: util-linux-core
Requires: /usr/bin/chcon
Requires: /usr/bin/systemctl
Requires: /usr/bin/zstd
chcon is being used by the bootc and recently added to bootc.spec file as an explicite requirement: bootc-dev/bootc#1391 When it is not presented in the system the result is failure of the `bootc install to-filesystem` command used by Anaconda installer.
chcon is being used by the bootc and recently added to bootc.spec file as an explicite requirement: bootc-dev/bootc#1391 When it is not presented in the system the result is failure of the `bootc install to-filesystem` command used by Anaconda installer.
We execute it, and Anaconda was somehow omitting this.
Also pull in util-linux-core because we also depend on that.
#1383 (comment)