More clippy #1552
Merged
More clippy #1552
+102
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of re-enabling clippy. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables more clippy lints and adds #[allow] attributes to silence new warnings. My review provides suggestions to refactor the code to properly fix these lints instead of just allowing them. This includes grouping function arguments into structs to resolve too_many_arguments warnings, and boxing a large enum variant to resolve a large_enum_variant warning. These changes will improve code maintainability and adhere more closely to Rust best practices.
jeckersb
approved these changes
Aug 26, 2025
Assisted-by: Claude Code Signed-off-by: Colin Walters <[email protected]>
jeckersb
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.