install/to-disk: Drop separate /boot by default #529
Merged
+52
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
bootpn-only-if-luks
branch
from
0b4e0d0 to
8647db5
Compare
In order to simplify what we're doing here, let's drop the separate `/boot` aka XBOOTLDR partition by default for the `to-disk --block-setup=direct` path (the default). We retain it when using `--block-setup=tpm2-luks` as it's required there. Notably this kills off a hardcoded "ext4 for /boot" which is suboptimal for many reasons. Longer term again I'd like to emphasize `install to-filesystem` with external installers, plus integrating external installation scripts as part of `bootc install to-disk`. xref: - bootc-dev#499 - bootc-dev#440 Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
bootpn-only-if-luks
branch
from
8647db5 to
e5548d8
Compare
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
…2.148 build(deps): bump libc from 0.2.147 to 0.2.148
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
Use cap_tempfile via cap_std_ext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify what we're doing here, let's drop the separate
/bootaka XBOOTLDR partition by default for theto-disk --block-setup=directpath (the default).We retain it when using
--block-setup=tpm2-luksas it's required there.Notably this kills off a hardcoded "ext4 for /boot" which is suboptimal for many reasons.
Longer term again I'd like to emphasize
install to-filesystemwith external installers, plus integrating external installation scripts as part ofbootc install to-disk.xref: