tests/integration: install libzstd-devel #586
Conversation
Signed-off-by: John Eckersberg <[email protected]>
jeckersb
force-pushed
the
integration-zstd
branch
from
1113e58 to
2295718
Compare
|
lgtm |
|
This also relates to 0455f80 - in chatting with @henrywang I was hoping that we could rework the integration tests to always start from our |
|
Hm well this fixes the zstd-sys thing, but now mock is failing and the logs are not particularly helpful - https://artifacts.osci.redhat.com/testing-farm/ab704601-09e0-4473-a945-c9dfbe5931b7/work-awsbf0m5vzu/plans/install-upgrade/aws/execute/data/guest/default-0/tests/integration/install-upgrade/rpm-build-1/output.txt |
|
I think it's because the framework is passing |
|
I'm not sure; maybe it's somehow a flake. I tried restarting the jobs. |
|
It's also possible that this was actually broken by #581 - I think I ended up merging without those jobs being run because they were running for over 2 hours and we had a big TF backlog. |
|
Ah I think we need to update the buildrequires from the spec in contrib/, testing that now locally to see if that's sufficient. |
Signed-off-by: John Eckersberg <[email protected]>
Seems to fix it for me locally, added a new commit with that, we'll see how it shakes out in CI |
|
Ah right. Hmm...I might lean a bit towards always fetching the spec from fedora instead. This is a classic problem with specs/dpkg/arch etc in upstream, it just bitrots as it's not canonical. (Actually though, in theory in Fedora we could make use of the "dynamic buildrequires" stuff to auto-determine from our source external dependencies we have, but not worth doing right now) |
|
It's actually kind of tempting to change ostree-ext to also just support forking off |
|
Now it looks like quay issues: |
|
I guess let's give the other jobs a little bit more time to see if they get farther. But if not, we can just merge over red for those too. |
|
Ooh no it looks like #581 did break more things:
|
After the initial changes to ostree-ext introducing support for zstd:chunked, which can be found in this pull request: ostreedev/ostree-rs-ext#615, an additional PR modified the dependency on zstd during build time to use pkg-config. You can review these changes in the pull request: ostreedev/ostree-rs-ext#628. These updates also required modifications to bootc, detailed in this pull request: bootc-dev/bootc#586. This commit mirrors those changes in rpm-ostree. With these changes, it will be possible to build RPMs on systems that do not have zstd-devel pre-installed in the build root.
container: Switch to cap-std when exporting to oci
Required to build zstd-sys - https://artifacts.osci.redhat.com/testing-farm/66cab0ec-1653-42ec-b482-a90001dbd65a/work-awskhuoovz0/plans/install-upgrade/aws/execute/data/guest/default-0/tests/integration/install-upgrade/rpm-build-1/output.txt