Use gauge to avoid dependency cycles in the benchmarks #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? |
|
Thanks Ryan! |
|
Released as 0.2.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15, we had to go through unfortunate contortions to modify the
haskell-ci-generated.travis.ymlscript to disable running benchmarks, sincevector-binary-instances' dependency oncriterionlead to dependency cycles (which confusecabal-install). To work around this, I employ a similar trick that I use in thereflectionlibrary: replacecriterionwithgauge, a lighter benchmarking library that doesn't depend onvector-binary-instances. With this, we can actually build the benchmarks on Travis, and best of all, we can completely automate the generation of the.travis.ymlscript.Pinging @bgamari. See also here for a successful Travis run of this patch (since Travis support for this repo is disabled, I believe).