Skip to content

Update my fork #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 25, 2020
Merged

Update my fork #1

merged 12 commits into from
Mar 25, 2020

Conversation

bpleshakov
Copy link
Owner

Fixes #

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

sliverc and others added 12 commits January 17, 2020 09:42
Fixes #751
Fixes #732

Test matrix build by looking to what is officially supported
by Django and DRF in there respective release notes.
Currently pyup causes a lot of noise so when looking at the closed
PR the real PRs can be easily overlooked.
As we only have test dependencies simply updating on a bi-weekly basis
should be sufficient.
…qual to endpoint (#763)

A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
If you submit a list with one object, for example, DJA will respond you with unobvious errors.
Fixes #759 

Pass self.instance as the first parameter when initializing the child serializer from a polymorphic serialiser. This does not affect basic functionality, but makes the child serializer instance consistent with its usage of instance and data, which can fix potential issues when extending serilaizers that are part of a polymorphic serializer.
* Update django-debug-toolbar from 2.1 to 2.2
* Update faker from 3.0.0 to 4.0.0
* Update pytest from 5.3.1 to 5.3.5
* Update pytest-django from 3.7.0 to 3.8.0
Fixes #621 

When adding a ResourceRelatedField to a serializer that is included in the polymorphic_serializers
list of a polymorphic serializer, the parent_model is not correctly resolved in get_related_resource_type: instead of resolving to the inherited type, the base type is resolved. This can cause an AttributeError if the field in question is not present on the base model.

We ran into this, and then found the closed and seemingly abandoned issue referenced above. This PR implements the fix suggested by the original author, who deserves all the credit. The example code has been expanded to trigger the error when running the test-suite.

Thanks in advance for your time and please let us know if you have any suggestions for improvement.
* Update sphinx from 2.4.1 to 2.4.3
* Update faker from 4.0.0 to 4.0.1
* Update sphinx from 2.4.3 to 2.4.4
* Update faker from 4.0.1 to 4.0.2
* Update pytest from 5.3.5 to 5.4.1
@bpleshakov bpleshakov merged commit 01e399d into bpleshakov:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants