forked from django-json-api/django-rest-framework-json-api
-
Notifications
You must be signed in to change notification settings - Fork 0
Update my fork #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently pyup causes a lot of noise so when looking at the closed PR the real PRs can be easily overlooked. As we only have test dependencies simply updating on a bi-weekly basis should be sufficient.
…qual to endpoint (#763) A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
If you submit a list with one object, for example, DJA will respond you with unobvious errors.
Fixes #759 Pass self.instance as the first parameter when initializing the child serializer from a polymorphic serialiser. This does not affect basic functionality, but makes the child serializer instance consistent with its usage of instance and data, which can fix potential issues when extending serilaizers that are part of a polymorphic serializer.
* Update django-debug-toolbar from 2.1 to 2.2 * Update faker from 3.0.0 to 4.0.0 * Update pytest from 5.3.1 to 5.3.5 * Update pytest-django from 3.7.0 to 3.8.0
Fixes #621 When adding a ResourceRelatedField to a serializer that is included in the polymorphic_serializers list of a polymorphic serializer, the parent_model is not correctly resolved in get_related_resource_type: instead of resolving to the inherited type, the base type is resolved. This can cause an AttributeError if the field in question is not present on the base model. We ran into this, and then found the closed and seemingly abandoned issue referenced above. This PR implements the fix suggested by the original author, who deserves all the credit. The example code has been expanded to trigger the error when running the test-suite. Thanks in advance for your time and please let us know if you have any suggestions for improvement.
* Update sphinx from 2.4.1 to 2.4.3 * Update faker from 4.0.0 to 4.0.1
* Update sphinx from 2.4.3 to 2.4.4 * Update faker from 4.0.1 to 4.0.2 * Update pytest from 5.3.5 to 5.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS