[CLOSED] Add a maxsize check for filetree resize…

[core-ai-bot]

Issue by ficristo
Saturday Jan 07, 2017 at 10:38 GMT
Originally opened as adobe/brackets#13026

---

… and now it is possible to pass a percentage value.
It replaces #9122 and #12829
This fixes #6822, I'm sorry to take a starter bug but I thought it was open long enough that's time to fix it.

@redmunds could you review?

---

ficristo included the following code: https://github.com/adobe/brackets/pull/13026/commits

[core-ai-bot]

Comment by ficristo
Saturday Jan 07, 2017 at 10:44 GMT

---

Argh... I noticed only now #10456.@redmunds WDYT?

[core-ai-bot]

Comment by redmunds
Sunday Jan 08, 2017 at 23:29 GMT

---

@ficristo I'm surprised this issue wasn't fixed long ago. Thanks for putting up a PR.

Your code works as advertised. LGTM.

@lucaslouca Brings up a good point in PR #10456:

Also important is the scenario when the Sidebar is at its maximum size (filling the whole window) and the user decreases the Window's width.

You can hit this case even when sidebar is less than 100%. I was going to try out this code, but the remote branch seems to have been deleted, so I'm not sure if it actually fixes that case.

Do you want to try to fix that in this PR? If not, this is worth merging anyway.

[core-ai-bot]

Comment by ficristo
Monday Jan 09, 2017 at 19:57 GMT

---

With the new commit, it should take care of the window resize.
I tryed to use maxsize= 100% but it has the old problem but I think it is fine for now.

[core-ai-bot]

Comment by redmunds
Tuesday Jan 10, 2017 at 20:25 GMT

---

@ficristo Nice. Works great. I have a minor suggestion, but feel free to merge PR as is.

When window size is reduced, you enforce that leftSidebar.width is <= window.width - rightSidebar.width. Why don't you also apply the 80% to that calculation? This will maintain the same behavior as when dragging leftSidebar with.

[core-ai-bot]

Comment by ficristo
Wednesday Jan 11, 2017 at 19:49 GMT

---

Now it should take care of the percentage.
But I noticed an issue with the selection of current file...

This happen if you:

• resize the filetree at max
• resize the window to go over the file tree
• make sure the filetree was resized automatically
• resize the window to enlarge it

[core-ai-bot]

Comment by redmunds
Thursday Jan 12, 2017 at 00:37 GMT

---

That only happens if there are enough files in WorkingSet to require scrollbars. That line is the shadow at bottom of WorkingSetView. The editor view is not getting refreshed.

[core-ai-bot]

Comment by ficristo
Friday Jan 13, 2017 at 18:59 GMT

---

Triggering the panelResizeUpdate and panelResizeEnd events seems to have fixed it.
Triggering only one had other side effects.
It feels a bit dirty but I don't have other ideas at the moment.

[core-ai-bot]

Comment by redmunds
Saturday Jan 14, 2017 at 20:33 GMT

---

@ficristo I think triggering those events is the correct fix, although panelResizeStart should also be called to satisfy the API. Also, 1 typo, then LGTM.

[core-ai-bot]

Comment by ficristo
Sunday Jan 15, 2017 at 16:11 GMT

---

I've added the call to panelResizeStart event and rebased.
Which is the typo?

[core-ai-bot]

Comment by redmunds
Tuesday Jan 17, 2017 at 15:53 GMT

---

LGTM

[core-ai-bot]

Comment by ficristo
Tuesday Jan 17, 2017 at 17:51 GMT

---

@redmunds@haslam22 Thank you for the review.