uBlock Origin support problems.

[buthed010203]

I was messing around with adblock settings trying to see why it wasn't blocking pages despite them being included in the default uBlock lists. I came to the conclusion that brave adblock doesnt properly interpret ||site^$doc as ||site^$document which ublock origin does do. This causes much of that badware list to become completely useless. Using ublock.org as an example, we can see that it is in the list as ||ublock.org^$doc but visiting it in brave doesn't block it. Adding the list manually at brave://adblock makes no difference either so it isn't that. Adding ||ublock.org^$doc as a custom filter also does not work. Adding ||ublock.org^$document does actually block the page (so does ||ublock.org^ FWIW). If you try opening the page with ublock origin installed, it will show that it has blocked ||ublock.org^$document because it automatically expands it. This issue probably exists in other forms but I don't really want to go looking for them right now.

TL;DR:
Brave adblock doesn't convert ||mysite.com^$doc into ||mysite.com^$document which causes pages to not be blocked despite them being included in default filter lists.

[antonok-edm]

@buthed010203 thanks for reporting! Not sure how that got missed, but now it should be supported as of fca9099 😃

[buthed010203]

Thanks for the quick fix 👍

[buthed010203]

@antonok-edm it would appear that the "all" option is also missing (along with a few of the things that all encompasses?) https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#all
I doubt that this is really used anywhere for compatibility but might be worth looking into

[antonok-edm]

Yep, unfortunately that's a little more complicated to add in (we don't currently have popup, inline-font, or inline-script either). But you're right in that it's not very commonly used, so it's not as high of a priority.

I've added a mention for it in #1