$all #460
Merged
$all #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 5459095 | Previous: d56be21 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1874774229 ns/iter (± 10126118) |
1727033355 ns/iter (± 11920489) |
1.09 |
rule-match-first-request/brave-list |
999564 ns/iter (± 6431) |
1005963 ns/iter (± 12764) |
0.99 |
blocker_new/brave-list |
210449159 ns/iter (± 1270776) |
220140757 ns/iter (± 5159081) |
0.96 |
memory-usage/brave-list-initial |
41763292 ns/iter (± 3) |
41408849 ns/iter (± 3) |
1.01 |
memory-usage/brave-list-after-1000-requests |
44356820 ns/iter (± 3) |
44004875 ns/iter (± 3) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
this won't include `popup`, `inline-script`, or `inline-font` for now due to lack of support for the individual options, but we may as well convert `$all` into all supported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't include
popup,inline-script, orinline-fontfor now due to lack of support for the individual options, but we may as well convert$allinto all supported types.partially addresses #1